feat(snuba): Add RPC protos for subscription details endpoint#149
Open
feat(snuba): Add RPC protos for subscription details endpoint#149
Conversation
|
The latest Buf updates on your PR. Results from workflow ci / buf-checks (pull_request).
|
phacops
requested changes
Nov 24, 2025
Collaborator
phacops
left a comment
phacops
left a comment
There was a problem hiding this comment.
We're usually not the source of truth for subscriptions, state is stored in Postgres. We have a cache when we store the alert query we generate based on what is given to us when creating the alert, as well as internal details.
This is not something we want to expose, it's internal details related to the EAP and won't help the product side much. I think you'd want to look at Postgres to get details about an alert.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is to enable the addition of a new RPC for retrieving information about an existing subscription.